This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFC] Remove unnecessary argument METHOD to valops.c:oload_method_static


The attached patch removes the unnecessary argument METHOD to
oload_method_static in valops.c

Doug had said (https://sourceware.org/ml/gdb-patches/2014-02/msg00889.html)
that it could be renamed to "oload_method_static_offset", but I am not
very sure we should change it to offset for this.  The return value is
used as an offset as in an offset of 1 or 0 to adjust for the 'this'
pointer if the method in question is static.  But, it does not produce
any other offset other than that.  Would "oload_method_static_p" be
better?

ChangeLog

        * valops.c (oload_method_static): Remove unnecessary argument
        METHOD.
        (find_overload_match): Update call to oload_method_static.
        (find_oload_champ): Likewise.

Attachment: cleanup_oload_method_static_v1.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]