This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv3 8/8] Tests for validate symbol file using build-id
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Fri, 28 Feb 2014 21:33:07 +0100
- Subject: Re: [patchv3 8/8] Tests for validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20140227213341 dot GI21121 at host2 dot jankratochvil dot net> <53108F04 dot 2000709 at redhat dot com>
On Fri, 28 Feb 2014 14:28:36 +0100, Pedro Alves wrote:
> On 02/27/2014 09:33 PM, Jan Kratochvil wrote:
> > +
> > +file delete -force -- "${binlibfiledirrun}"
> > +file mkdir "${binlibfiledirrun}"
>
> Looks like as is, the test should be skipped when remote host testing?
The file is already skipped for non-gdbserver (=NAT) mode as linux-nat does
not support build-id reporting...
I have added there:
if { [board_info target sockethost] != "localhost:" } {
# The testcase below could be fixed for remote targets.
untested "only gdbserver on localhost is supported (found [board_info target sockethost])"
return -1
}
I do not feel a chance to get it right without testing on real two-host remote
setup and I do not think it is needed as a regression would be found first
during gdbserver run on localhost anyway.
Is it acceptable that way? Someone on gdb-patches was fixing testcases from
time to time to run on real non-localhost remote configurations. When such
configuration is already setup it is easier to fix all such skipped testcases.
Jan