This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] PR python/16483 (info frame-filters is too verbose)
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 28 Feb 2014 11:59:52 -0700
- Subject: Re: [patch][python] PR python/16483 (info frame-filters is too verbose)
- Authentication-results: sourceware.org; auth=none
- References: <5307634D dot 7080203 at redhat dot com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> + self.print_empty = False
Nothing ever seems to set this. I think it can be dropped.
Phil> + self.total_filters = 0
This is initialized in the command's constructor and never reset to 0.
I think this means the command won't work properly if filters are ever
unregistered.
Otherwise I think this looks good.
Tom