This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFC] Unnecessary argument METHOD to valops.c:find_oload_champ?


Hi,

This patch is possibly a cleanup, but I am not sure.

There exists a argument METHOD to find_oload_champ in valops.c which
seems to me like it is unnecessary. I did a bit of excavation and
found that it has existed ever since the function was added to
valops.c. The attached patch removes this argument. Though the change
is fairly straightforward and mechanical, I have regression tested to
make sure nothing is broken.

Why I want this change? My change to find_oload_champ in my debug
methods patch is a bit ugly. This cleanup will help make it better.
For reference, my debug methods patch:
https://sourceware.org/ml/gdb-patches/2014-02/msg00816.html

ChangeLog
2014-02-27  Siva Chandra Reddy  <sivachandra@google.com>

        * valops.c (find_oload_champ): Remove unneccesary argument METHOD
        (find_overload_match): Update call to find_oload_champ.
        (find_oload_champ_namespace_loop): Likewise

Thanks,
Siva Chandra

Attachment: find_oload_champ_patch_v1.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]