This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/3] gdbserver/windows: Ignore DLL load/unload events during child initialization.
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 26 Feb 2014 18:29:53 +0000
- Subject: Re: [RFA 1/3] gdbserver/windows: Ignore DLL load/unload events during child initialization.
- Authentication-results: sourceware.org; auth=none
- References: <1393284074-9889-1-git-send-email-brobecker at adacore dot com> <1393284074-9889-2-git-send-email-brobecker at adacore dot com>
On 02/24/2014 11:21 PM, Joel Brobecker wrote:
> gdb/gdbserver/ChangeLog:
>
> * win32-low.c (win32_add_all_dlls): Renames
> win32_ensure_ntdll_loaded. Rewrite function documentation.
> Adjust implementation to always load all DLLs.
> Add 0x1000 offset to DLL base address when calling
> win32_add_one_solib.
> (child_initialization_done): New static global.
> (do_initial_child_stuff): Set child_initialization_done to
> zero during child initialization, and 1 after. Replace call
> to win32_ensure_ntdll_loaded by call to win32_add_all_dlls.
> Add comment.
> (match_dll_by_basename, dll_is_loaded_by_basename): Delete.
> (handle_unload_dll): Add function documentation.
> (get_child_debug_event): Ignore load and unload DLL events
> during child initialization.
Looks good, thanks!
--
Pedro Alves