This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory
- From: Yao Qi <yao at codesourcery dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc: <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Fri, 21 Feb 2014 21:20:07 +0800
- Subject: Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory
- Authentication-results: sourceware.org; auth=none
- References: <87ios8fwf9 dot fsf at br87z6lw dot de dot ibm dot com>
On 02/21/2014 09:05 PM, Andreas Arnez wrote:
> @@ -1348,7 +1348,7 @@ memory_xfer_partial (struct target_ops *ops, enum target_object object,
> xfered_len);
>
> if (res == TARGET_XFER_OK && !show_memory_breakpoints)
> - breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, res);
> + breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, *xfered_len);
Ah, it should be "*xfered_len" instead of "res". The patch looks good
to me, but I can't approve it.
--
Yao (éå)