This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PING: [PATCH v4] fixed inherit_abstract_dies infinite recursive call
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Feb 2014 18:48:21 +0100
- Subject: Re: PING: [PATCH v4] fixed inherit_abstract_dies infinite recursive call
- Authentication-results: sourceware.org; auth=none
- References: <20140210142831 dot GY5485 at adacore dot com> <CAP9bCMSh7VPM2HZ8RYeq+Nhcc78txiqZ9X=t+oaX6d_Zh_f6Uw at mail dot gmail dot com> <20140211021937 dot GD5485 at adacore dot com> <CAP9bCMTw8syKZU=1-EUJsuzw61J9UsR6Lv-hO_C5B_E-Em-1FA at mail dot gmail dot com> <20140213073112 dot GS5485 at adacore dot com> <52FC7BC8 dot 2010400 at gmail dot com> <20140214033411 dot GD5485 at adacore dot com> <m3mwhnvbrk dot fsf at sspiff dot org> <20140219075900 dot GC4270 at adacore dot com> <CAP9bCMQzx4z005Jn7KShg-yGDJ_grL5AV3XurBJNJEcTCeEJyA at mail dot gmail dot com>
> >> 2014-02-18 lin zuojian <manjian2006@gmail.com>
> >> Joel Brobecker <brobecker@adacore.com>
> >> Doug Evans <xdje42@gmail.com>
> >>
> >> PR symtab/16581
> >> * dwarf2read.c (struct die_info): New member in_process.
> >> (reset_die_in_process): New function.
> >> (process_die): Set it at the start, reset when returning.
> >> (inherit_abstract_dies): Only call process_die if origin_child_die
> >> not already being processed.
> >>
> >> testsuite/
> >> * gdb.dwarf2/dw2-icycle.S: New file.
> >> * gdb.dwarf2/dw2-icycle.c: New file.
> >> * gdb.dwarf2/dw2-icycle.exp: New file.
[...]
> Committed.
> [with a small tweak to the testcase (added a comment)]
I noticed something as well (in my testcase), which I think will make
it fail with an ARM bare-metal compiler. Fix attached and pushed.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-icycle.S: Remove second and third parameters
in .section pseudo-op.
Tested on x86_64-linux...
--
Joel
>From 83deb43f87f098f7858db8643786301eb73875f7 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 20 Feb 2014 18:34:45 +0100
Subject: [PATCH] Simplify .section in dw2-icycle.S
The arm-elf assembler chokes on the extra parameters in the .section
pseudo-op, so this patch removes them.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-icycle.S: Remove second and third parameters
in .section pseudo-op.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.dwarf2/dw2-icycle.S | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 52dff12..d1d99f8 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-02-20 Joel Brobecker <brobecker@adacore.com>
+
+ * gdb.dwarf2/dw2-icycle.S: Remove second and third parameters
+ in .section pseudo-op.
+
2014-02-20 lin zuojian <manjian2006@gmail.com>
Joel Brobecker <brobecker@adacore.com>
Doug Evans <xdje42@gmail.com>
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icycle.S b/gdb/testsuite/gdb.dwarf2/dw2-icycle.S
index 6bc533a..1f84e4a 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-icycle.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-icycle.S
@@ -33,7 +33,7 @@ p__top:
.LFE2:
.Letext0:
- .section .debug_info,"",@progbits
+ .section .debug_info
.Ldebug_info0:
.4byte .Ledebug_info0 - .Lsdebug_info0 /* Length of CU Info */
.Lsdebug_info0:
@@ -118,7 +118,7 @@ p__top:
.byte 0 /* end of children of DIE 0xb */
.Ledebug_info0:
- .section .debug_abbrev,"",@progbits
+ .section .debug_abbrev
.Ldebug_abbrev0:
.uleb128 0x1 /* (abbrev code) */
.uleb128 0x11 /* (TAG: DW_TAG_compile_unit) */
--
1.8.3.2