Re: [patch] testsuite: Fix "ERROR: no fileid for"

["Maciej W. Rozycki" <macro at codesourcery dot com>]

Hi Jan,

> ping: I expect you are fine with this "incomplete" fix so I will check it in.

 Yes, I am.

> > > Can you provide a more elaborate log of your test session?
> > 
> > $ echo 'set gdbserver_reconnect_p 1' >test.exp;runtest test.exp
> > 
> > > What are the exact conditions for this problem to trigger?
> > 
> > If GDB does not run and the testsuite tries to close down it errors.
> > 
> > 
> > >  I'm asking because I fear your change could defeat the purpose of the 
> > > commit you referred to if there's a catastrophic failure causing GDB to 
> > > crash while running gdb.base/solib-disc.exp -- in such a case an instance 
> > > of gdbserver would stay behind running, ruining the remaining part of the 
> > > test suite in environments where only a single TCP port is available for 
> > > the RSP connection.
> > 
> > If GDB has crashed then gdb_spawn_id still exists (although it does not work).
> > So my patch does not change anything.  And also currently it will leave the
> > stale gdbserver running anyway.

 Correct.  I wasn't sure of the spawn ID situation, thanks for the 
clarification.

> > In general if gdb_spawn_id does not exist then send_gdb + gdb_expect just do
> > not make sense anyway.  So this patch just prevents the error in such case.

 I'm still curious as to the actual use for such a scenario, but from the 
corectness POV your fix is valid indeed.

> > The killing of stale gdbserver could be improved multiple ways (also as
> > suggested by Pedro in the original thread) but that is IMO outside of the
> > scope of this patch.  Apparently if there is no good response from GDB then
> > gdb_finish() should try to call gdb_start just to kill that gdbserver, IIUC.

 So do I.  Thanks for your fix and apologies for the delay.

  Maciej