This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/elfread.c: Enable ifunc support on ARM.
- From: Pedro Alves <palves at redhat dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Mon, 10 Feb 2014 15:56:55 +0000
- Subject: Re: [PATCH] gdb/elfread.c: Enable ifunc support on ARM.
- Authentication-results: sourceware.org; auth=none
- References: <52AF4563 dot 2090304 at linaro dot org> <52F3C99F dot 5060500 at redhat dot com> <CANu=DmhH9dtJ2LRRdfFhpERWhAER4e_gEaHHUDQqStqYWA6GCA at mail dot gmail dot com>
On 02/10/2014 02:57 PM, Will Newton wrote:
> Thanks for taking a look.
>
>> Couple notes:
>>
>> - I think you can look at 'get_elf_backend_data (abfd)->want_got_plt'
>> to decide whether to look up ".got" vs ".got.plt".
>
> I don't think that will work. We actually want to look at the value of
> SEPARATE_GOTPLT I believe, which I don't think we can easily
> determine. For example, ARM sets want_got_plt but not SEPARATE_GOTPLT.
Alright. Lets go with your original patch then. Patch is OK.
Thanks,
--
Pedro Alves