This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC v2 37/38] fix buglet in nto-procfs.c
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at redhat dot com>
- Date: Thu, 6 Feb 2014 13:55:35 -0700
- Subject: [RFC v2 37/38] fix buglet in nto-procfs.c
- Authentication-results: sourceware.org; auth=none
- References: <1391720136-2121-1-git-send-email-tromey at redhat dot com>
I happened to notice that nto-procfs.c defines
procfs_remove_hw_breakpoint but never uses it. This caused it not to
be updated by my target-method-updating script. This patch fixes the
function and installs it properly. I have no way to test this,
however.
2014-02-06 Tom Tromey <tromey@redhat.com>
* nto-procfs.c (procfs_remove_hw_breakpoint): Add 'self'
argument.
(init_procfs_ops): Correctly set to_remove_hw_breakpoint.
---
gdb/ChangeLog | 6 ++++++
gdb/nto-procfs.c | 5 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
index 1b2b2ff..d0bdc90 100644
--- a/gdb/nto-procfs.c
+++ b/gdb/nto-procfs.c
@@ -947,7 +947,8 @@ procfs_insert_hw_breakpoint (struct target_ops *self, struct gdbarch *gdbarch,
}
static int
-procfs_remove_hw_breakpoint (struct gdbarch *gdbarch,
+procfs_remove_hw_breakpoint (struct target_ops *self,
+ struct gdbarch *gdbarch,
struct bp_target_info *bp_tgt)
{
return procfs_breakpoint (bp_tgt->placed_address,
@@ -1402,7 +1403,7 @@ init_procfs_ops (void)
procfs_ops.to_remove_breakpoint = procfs_remove_breakpoint;
procfs_ops.to_can_use_hw_breakpoint = procfs_can_use_hw_breakpoint;
procfs_ops.to_insert_hw_breakpoint = procfs_insert_hw_breakpoint;
- procfs_ops.to_remove_hw_breakpoint = procfs_remove_breakpoint;
+ procfs_ops.to_remove_hw_breakpoint = procfs_remove_hw_breakpoint;
procfs_ops.to_insert_watchpoint = procfs_insert_hw_watchpoint;
procfs_ops.to_remove_watchpoint = procfs_remove_hw_watchpoint;
procfs_ops.to_stopped_by_watchpoint = procfs_stopped_by_watchpoint;
--
1.8.1.4