This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/Patch v4] Call overloaded operators to perform valid Python operations on struct/class values.


> Date: Sun, 02 Feb 2014 22:59:01 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: dje@google.com, gdb-patches@sourceware.org, tromey@redhat.com
> 
> > Date: Sun, 2 Feb 2014 12:06:31 -0800
> > From: Siva Chandra <sivachandra@google.com>
> > Cc: gdb-patches <gdb-patches@sourceware.org>, Tom Tromey <tromey@redhat.com>
> > 
> > +operator.  In general, overloaded operators are invoked for the
> > +following operators: @code{+} (binary addition), @code{-} (binary
>              ^^^^^^^^^
> I'd suggest "operations" here.
> 
> > +subtraction), @code{*} (multiplication), @code{/}, @code{%}, @code{<<},
> > +@code{>>}, @code{|}, @code{&}, @code{^}.
> 
> OK with those changes.

Another gotcha that somehow got deleted from the mail I prepared:

> +For example, if @code{val1}and @code{val2} are @code{gdb.Value} objects
                             ^^
Missing space.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]