This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Regression setting breakpoint


> Not really a code review, but the ChangeLog entries should be of the
> form:
> 
> 2014-01-16  Your Name  <you@email.com>
> 
> 	* file.c (function): What changed.

FWIW, I have been using:

| gdb/ChangeLog:
|
|         * file.c (function): What changed.
|
| gdb/testsuite/ChangeLog:
|
|         * gdb.base/file.exp: Bla bla bla.

Two reasons: It makes it obvious which ChangeLog the entries refer to,
and it avoids the need to put a date in the revision log, which may
become obe due to the time it takes to get the patch in after it is
written.

The format with dates are accepted as well, of course. And I have
seen people add the directory usually on the line just ahead of
the CL entry. Eg:

| gdb/:
| 2014-01-16  Your Name  <you@example.com>

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]