This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] psymtab.c cleanup: Move expand_partial_symbol_names.
- From: Doug Evans <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 14 Jan 2014 18:38:24 -0800
- Subject: Re: [PATCH 1/3] psymtab.c cleanup: Move expand_partial_symbol_names.
- Authentication-results: sourceware.org; auth=none
- References: <yjt2siu5liqq dot fsf at ruffy dot mtv dot corp dot google dot com>
Doug Evans writes:
> Hi.
>
> This is the first of a set of three patches to cleanup psymtab.c a bit.
>
> Basically, these two functions do not belong in psymtab.c:
> expand_partial_symbol_names, map_partial_symbol_filenames,
> and "partial" does not belong in the function name.
>
> This first patch moves them to a better location.
> The second patch adds some typedefs for function parameters to
> quick_symbol_functions.expand_symtabs_matching.
> The third patch removes "partial" from the function names
> and uses them in more places.
>
> Regression tested on amd64-linux.
> [Hey, I remembered to say that this time. :-)]
>
> 2013-12-06 Doug Evans <dje@google.com>
>
> * psymtab.c (expand_partial_symbol_names): Delete, moved to symfile.c.
> (map_partial_symbol_filenames): Ditto.
> * psymtab.h (expand_partial_symbol_names): Delete, moved to symfile.h.
> (map_partial_symbol_filenames): Ditto.
> * symfile.c (expand_partial_symbol_names): Moved here from psymtab.c.
> (map_partial_symbol_filenames): Ditto.
> * symfile.h (expand_partial_symbol_names): Moved here from psymtab.h.
> (map_partial_symbol_filenames): Ditto.
> * symtab.c: Delete #include "psymtab.h".
I have committed this.