This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Target-description enhancement for typed-bitfield and enum-type.
- From: Yao Qi <yao at codesourcery dot com>
- To: Wei-cheng Wang <cole945 at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>, <wtedeschi at sourceware dot org>, <best124612 at gmail dot com>, <jasonwucj at gmail dot com>
- Date: Wed, 18 Dec 2013 09:45:28 +0800
- Subject: Re: Target-description enhancement for typed-bitfield and enum-type.
- Authentication-results: sourceware.org; auth=none
- References: <52AF2B1F dot 2030500 at gmail dot com>
On 12/17/2013 12:32 AM, Wei-cheng Wang wrote:
> This is a patch supporting target-description typed-bitfield and enum-type.
>
> Current bitfield doesn't support explicit type.
> However, the formats of non-GPRs are usually complex. It's not friendly
> to represent such registers by a simple numeric.
> For example, CPSR register of ARM.
>
> (gdb) p $cpsr
> $1 = 1610612784
>
> With this patch, we could use target-description to describe
> complex register formats, for example
>
> (gdb) p $cpsr
> $1 = {[ T C Z ], M = User, IT_cond = 0, GE = 0, DNM = 0}
>
Hi Wei-cheng,
I am unable to apply your patch.
$ git am ../Target-description\ enhancement\ for\ typed-bitfield\ and\ enum-type.eml
Applying: Target-description enhancement for typed-bitfield and enum-type.
error: patch failed: gdb/features/gdb-target.dtd:45
error: gdb/features/gdb-target.dtd: patch does not apply
error: patch failed: gdb/target-descriptions.c:132
error: gdb/target-descriptions.c: patch does not apply
error: patch failed: gdb/target-descriptions.h:235
error: gdb/target-descriptions.h: patch does not apply
error: patch failed: gdb/xml-tdesc.c:286
error: gdb/xml-tdesc.c: patch does not apply
error: patch failed: gdb/features/i386/amd64-mpx-linux.c:178
error: gdb/features/i386/amd64-mpx-linux.c: patch does not apply
error: patch failed: gdb/features/i386/amd64-mpx.c:173
error: gdb/features/i386/amd64-mpx.c: patch does not apply
error: patch failed: gdb/features/i386/i386-mpx-linux.c:154
error: gdb/features/i386/i386-mpx-linux.c: patch does not apply
error: patch failed: gdb/features/i386/i386-mpx.c:149
error: gdb/features/i386/i386-mpx.c: patch does not apply
Patch failed at 0001 Target-description enhancement for typed-bitfield and enum-type.
I also coped your patch to a text file and try "patch -p1". No success
either. Probably it is about email setting.
IWBN to mention the rationale or general description of this patch. The
example you gave is good, but it's better to say why do you change code
in this way. Please have a look at section 2 and 7
https://sourceware.org/gdb/wiki/ContributionChecklist
--
Yao (éå)