This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] change probes to be program-space-independent
- From: Gary Benson <gbenson at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Dec 2013 11:08:44 +0000
- Subject: Re: [PATCH 3/4] change probes to be program-space-independent
- Authentication-results: sourceware.org; auth=none
- References: <1386100019-27379-1-git-send-email-tromey at redhat dot com> <1386100019-27379-4-git-send-email-tromey at redhat dot com>
Tom Tromey wrote:
> This changes the probes to be independent of the program space.
>
> After this, when a probe's address is needed, it is determined by
> applying offsets at the point of use.
>
> This introduces a bound_probe object, similar to bound minimal
> symbols. Objects of this type are used when it's necessary to pass a
> probe and its corresponding objfile.
>
> This removes the backlink from probe to objfile, which was primarily
> used to fetch the architecture to use.
>
> This adds a get_probe_address function which calls a probe method to
> compute the probe's relocated address. Similarly, it adds an objfile
> parameter to the semaphore methods so they can do the relocation
> properly as well.
I haven't looked at the whole patch, but the solib-svr4.c bits look
good. Thanks for doing this work Tom.
Cheers,
Gary
--
http://gbenson.net/