This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Extend SystemTap SDT probe argument parser
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 16 Dec 2013 15:16:09 -0200
- Subject: Re: [PATCH] Extend SystemTap SDT probe argument parser
- Authentication-results: sourceware.org; auth=none
- References: <1386734160-29837-1-git-send-email-sergiodj at redhat dot com> <m3fvps20i5 dot fsf at redhat dot com> <201312161708 dot rBGH8m8L017003 at glazunov dot sibelius dot xs4all dot nl>
On Monday, December 16 2013, Mark Kettenis wrote:
>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Date: Mon, 16 Dec 2013 15:01:38 -0200
>>
>> On Wednesday, December 11 2013, I wrote:
>>
>> > This patch extends the current generic parser for SystemTap SDT probe
>> > arguments. It can be almost considered a cleanup, but the main point of
>> > it is actually to allow the generic parser to accept multiple prefixes
>> > and suffixes for the its operands (i.e., integers, register names, and
>> > register indirection).
>>
>> Ping.
>
> Can't say I like the added complexity, but the i386/amd64 are ok.
Thanks for the approval.
I wonder what exactly you didn't like, and if you have some opinion on
how to improve it.
Thanks,
--
Sergio