This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR gdb/16305: Mask out PREFIX_ADDR when adding prefix to opcode
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: GDB <gdb-patches at sourceware dot org>
- Date: Sat, 14 Dec 2013 15:15:12 -0800
- Subject: Re: [PATCH] PR gdb/16305: Mask out PREFIX_ADDR when adding prefix to opcode
- Authentication-results: sourceware.org; auth=none
- References: <20131208201430 dot GA14252 at intel dot com>
On Sun, Dec 08, 2013 at 12:14:30PM -0800, H.J. Lu wrote:
> PREFIX_ADDR isn't a prefix to opcode. This patch masks out PREFIX_ADDR
> when adding prefix to opcode. Tested on Linux/x86-64. OK to install?
>
> Thanks.
>
> H.J.
> ---
> 2013-12-08 H.J. Lu <hongjiu.lu@intel.com>
>
> PR gdb/16305
> * i386-tdep.c (i386_process_record): Mask out PREFIX_ADDR when
> adding prefix to opcode.
> ---
> gdb/i386-tdep.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index 371d5f0..6635a25 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -7031,7 +7031,8 @@ no_support_3dnow_data:
> case 0x0ffc:
> case 0x0ffd:
> case 0x0ffe:
> - switch (prefixes)
> + /* Mask out PREFIX_ADDR. */
> + switch ((prefixes & ~PREFIX_ADDR))
> {
> case PREFIX_REPNZ:
> opcode |= 0xf20000;
> --
> 1.8.3.1
>
Hi Mark,
Do you get time to review this one-line change?
Thanks.
H.J.