Re: [RFC/Patch] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects

[Siva Chandra <sivachandra at google dot com>]

Sorry for double posting, I missed attaching the patch with the previous post.

2013-12-08  Siva Chandra Reddy  <sivachandra@google.com>

        PR 16113: Allow gdb.Field objects with the subscript operator on
        gdb.Value objects of struct/class values.
        * NEWS (Python Scripting): Add entry for the new feature.
        * python/py-type.c (gdbpy_is_field): New function
        * python/py-value.c (valpy_getitem): Allow subscript value to be
        a gdb.Field object.
        (value_has_field): New function
        (get_field_flag): New function
        * python/python-internal.h (gdbpy_is_field): Add declaration.

        testsuite/
        * gdb.python/py-value-cc.cc: Improve test case.
        * gdb.python/py-value-cc.exp: Add new tests.

        doc/
        * gdb.texinfo (Values From Inferior): Add a note about using
        gdb.Field objects as subscripts on gdb.Value objects.

On Sun, Dec 8, 2013 at 5:02 PM, Siva Chandra <sivachandra@google.com> wrote:
> Hi,
>
> The attached patch addresses the marked PR. The doc and NEWS changes
> are incomplete as it depends on whether the route I have taken in this
> patch is acceptable. I will fill them after I get (dis/)approval.
> Other changes to the doc and NEWS are present.
>
> 2013-12-08  Siva Chandra Reddy  <sivachandra@google.com>
>
>         PR 16113: Allow gdb.Field objects with the subscript operator on
>         gdb.Value objects of struct/class values.
>         * NEWS (Python Scripting): Add entry for the new feature.
>         * python/py-type.c (gdbpy_is_field): New function
>         * python/py-value.c (valpy_getitem): Allow subscript value to be
>         a gdb.Field object.
>         (value_has_field): New function
>         (get_field_flag): New function
>         * python/python-internal.h (gdbpy_is_field): Add declaration.
>
>         testsuite/
>         * gdb.python/py-value-cc.cc: Improve test case.
>         * gdb.python/py-value-cc.exp: Add new tests.
>
>         doc/
>         * gdb.texinfo (Values From Inferior): Add a note about using
>         gdb.Field objects as subscripts on gdb.Value objects.

Attachment: value_field_subscript_patch_v1.txt
Description: Text document