This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Add software single stepping to moxie port
- From: Anthony Green <green at moxielogic dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 06 Dec 2013 14:38:57 -0500
- Subject: Re: [commit] Add software single stepping to moxie port
- Authentication-results: sourceware.org; auth=none
- References: <87wqjj1ftc dot fsf at moxielogic dot com> <52A1214E dot 8070006 at codesourcery dot com>
Yao Qi <yao@codesourcery.com> writes:
> On 12/05/2013 11:24 PM, Anthony Green wrote:
>> +static ULONGEST
>> +moxie_process_readu (CORE_ADDR addr, gdb_byte *buf,
>> + int length, enum bfd_endian byte_order)
>> +{
>> + if (target_read_memory (addr, buf, length))
>> + {
>> + if (record_debug)
>> + printf_unfiltered (_("Process record: error reading memory at "
>> + "addr 0x%s len = %d.\n"),
>> + paddress (target_gdbarch (), addr), length);
>
> moxie_process_readu is only used in moxie_process_record, so the debug
> message is OK. However, if we'll use moxie_process_readu in
> software_single_step, the debug message looks odd.
Good point. I'll fix that.
Thanks,
AG