This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, nios2] Update Linux parts for new syscall ABI
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Sandra Loosemore <sandra at codesourcery dot com>
- Date: Mon, 2 Dec 2013 07:23:33 +0400
- Subject: Re: [patch, nios2] Update Linux parts for new syscall ABI
- Authentication-results: sourceware.org; auth=none
- References: <529AF143 dot 9060704 at codesourcery dot com>
> This patch updates the nios2-linux code for the new Linux generic system
> call interface. Mainly removing (non-rt) sigreturn related definitions,
> and updating the rt_sigreturn syscall NR.
>
> Will commit after Sandra's approval.
I am sorry to be so procedural, but while Sandra input would probably
be more valuable than most, Sandra is not yet listed as maintainer
in GDB. She can therefore not approve patches for commit in the official
repository yet. It should all be documented in gdb/MAINTAINERS.
> 2013-12-01 Chung-Lin Tang <cltang@codesourcery.com>
>
> gdb/
> * nios2-linux-tdep.c (nios2_linux_sigreturn_init): Remove.
> (nios2_linux_sigreturn_tramp_frame): Remove.
> (nios2_linux_rt_sigreturn_tramp_frame): Update rt_sigreturn syscall
> number.
> (nios2_linux_syscall_next_pc): Likewise. Remove sigreturn case.
> (nios2_linux_init_abi):
> Remove registration of nios2_linux_sigreturn_tramp_frame.
My concern with your patch is that it seems to eliminate support for
the previous syscall ABI, which means a break in compatibility. Unless
we really have no other choice, I don't think we would want that.
--
Joel