This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64


>>>>> "Marcus" == Marcus Shawcroft <marcus.shawcroft@gmail.com> writes:

Marcus> Sorry, I was not clear. I think the a64 and a32 parsers should be kept
Marcus> separate rather than using a common parser for a different, but
Marcus> similar syntax, thus avoiding the need to pass the flag that
Marcus> distinguishes the different syntaxes.

It seems reasonable to me.
It looks to me like the current function arm_stap_parse_special_token is
the only code shared by the patch.  That isn't so long by itself, and
then if it needs tweaks for AArch64 -- one might as well just copy it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]