This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/8] remove some stale FIXMEs
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 27 Nov 2013 10:08:14 -0700
- Subject: Re: [PATCH 4/8] remove some stale FIXMEs
- Authentication-results: sourceware.org; auth=none
- References: <1385502587-29757-1-git-send-email-tromey at redhat dot com> <1385502587-29757-5-git-send-email-tromey at redhat dot com> <5295D6FC dot 7030508 at redhat dot com> <87vbzd3nwa dot fsf at fleche dot redhat dot com>
Tom> I'll fix it.
Here's a new version.
Tom
commit 370f78a0c0bdb770d21abc3dccb61da4ed3574eb
Author: Tom Tromey <tromey@redhat.com>
Date: Mon Nov 25 08:47:51 2013 -0700
fix a couple of FIXMEs
This fixes a couple of old "32x64" FIXME comments by using paddress
with current_gdbarch rather than hex_string and a cast to long.
2013-11-26 Tom Tromey <tromey@redhat.com>
* cli/cli-cmds.c (edit_command): Use paddress, not hex_string.
(list_command): Likewise.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0bda3bb..d059474 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2013-11-26 Tom Tromey <tromey@redhat.com>
+ * cli/cli-cmds.c (edit_command): Use paddress, not hex_string.
+ (list_command): Likewise.
+
+2013-11-26 Tom Tromey <tromey@redhat.com>
+
* psymtab.c (allocate_psymtab): Put the filename in the filename
bcache.
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 85f1713..52a6bc9 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -817,9 +817,8 @@ edit_command (char *arg, int from_tty)
struct gdbarch *gdbarch;
if (sal.symtab == 0)
- /* FIXME-32x64--assumes sal.pc fits in long. */
error (_("No source file for address %s."),
- hex_string ((unsigned long) sal.pc));
+ paddress (get_current_arch (), sal.pc));
gdbarch = get_objfile_arch (sal.symtab->objfile);
sym = find_pc_function (sal.pc);
@@ -982,9 +981,8 @@ list_command (char *arg, int from_tty)
struct gdbarch *gdbarch;
if (sal.symtab == 0)
- /* FIXME-32x64--assumes sal.pc fits in long. */
error (_("No source file for address %s."),
- hex_string ((unsigned long) sal.pc));
+ paddress (get_current_arch (), sal.pc));
gdbarch = get_objfile_arch (sal.symtab->objfile);
sym = find_pc_function (sal.pc);