This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] handle an unspecified return address column
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Tue, 26 Nov 2013 18:37:27 +0400
- Subject: Re: [PATCH 2/2] handle an unspecified return address column
- Authentication-results: sourceware.org; auth=none
- References: <1384375873-32160-1-git-send-email-tromey at redhat dot com> <1384375873-32160-3-git-send-email-tromey at redhat dot com> <20131126133446 dot GA28596 at adacore dot com> <201311261348 dot rAQDmBs1032481 at glazunov dot sibelius dot xs4all dot nl> <20131126135519 dot GI3114 at adacore dot com> <201311261430 dot rAQEUFIu001724 at glazunov dot sibelius dot xs4all dot nl>
> Pretty much both. The original diff was clearly wrong, and it is best
> to have the history reflect that clearly. But it will also make the
> review easier. To be honest, I think the conditional, after your
> modification, is too confusing.
OK. It's Tom's commit, so I will wait for his input before undoing
the change.
> Didn't realize that the tests were part of the same commit though. So
> you probably can't simply use git revert. Perhaps that means we
> should commit testsuite changes seperately in the future.
It's easy to undo just part of the commit, still keeping the testcase.
We can't use "git revert" anyways, because of those $(&! ChangeLog
files, nearly always triggerring revert conflict. And the sad part
is that we actually want those, because we do not want to undo the
ChangeLog entry!
--
Joel