This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
- From: Pedro Alves <palves at redhat dot com>
- To: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- Cc: "yao at codesourcery dot com" <yao at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 25 Nov 2013 14:39:58 +0000
- Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
- Authentication-results: sourceware.org; auth=none
- References: <1385386802-16948-1-git-send-email-walfred dot tedeschi at intel dot com> <52935D6A dot 1060301 at redhat dot com> <AC542571535E904D8E8ADAE745D60B191B1DBF4E at IRSMSX104 dot ger dot corp dot intel dot com>
On 11/25/2013 02:32 PM, Tedeschi, Walfred wrote:
> This should be the fix. The issue was that the buffer size was not matching the size actually read.
I'm staring at the patch, and not seeing what the actual functional
change was. Can you point it out? That's the sort of thing that helps
review, and that is good to have in the email/commit log -- a rationale
for the fix, an explanation of what was wrong, how the fix actually fixes it, etc.
> Macro was really broken, for any XCR0 value it was returning 576, as pointed by Joel:
> https://sourceware.org/ml/gdb-patches/2013-11/msg00761.html
>
> I have tested the macros on an ad-hoc application to verify its functionality.
>
> Do you still see the issue when applying this?
I haven't tried it yet. I'll do that now.
Thanks,
--
Pedro Alves