This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [pushed] [PATCH V7 0/8] Intel(R) MPX register support
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Yao Qi <yao at codesourcery dot com>, "Mark Kettenis (mark dot kettenis at xs4all dot nl)" <mark dot kettenis at xs4all dot nl>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 25 Nov 2013 08:15:25 +0000
- Subject: RE: [pushed] [PATCH V7 0/8] Intel(R) MPX register support
- Authentication-results: sourceware.org; auth=none
- References: <AC542571535E904D8E8ADAE745D60B191B1D8BC7 at IRSMSX104 dot ger dot corp dot intel dot com> <528E62B3 dot 7080005 at redhat dot com> <AC542571535E904D8E8ADAE745D60B191B1D9C3D at IRSMSX104 dot ger dot corp dot intel dot com> <87siuocq7e dot fsf at fleche dot redhat dot com>
Tom,
Thanks for clarifying this, fort the next series we will add a remark on the patches to be squashed.
Best regards,
-Fred
-----Original Message-----
From: Tom Tromey [mailto:tromey@redhat.com]
Sent: Friday, November 22, 2013 6:16 PM
To: Tedeschi, Walfred
Cc: Pedro Alves; Yao Qi; Mark Kettenis (mark.kettenis@xs4all.nl); gdb-patches@sourceware.org
Subject: Re: [pushed] [PATCH V7 0/8] Intel(R) MPX register support
>>>>> ">" == Tedeschi, Walfred <walfred.tedeschi@intel.com> writes:
>> BTW: Next patch we will squash i386/amd64/gdbserver. Should this
>> three patches also be send for review as a single commit?
Usually it's best to make each patch work independently. This is the ideal because then one doesn't need to do anything special when submitting or merging.
Of course, it isn't always possible. Sometimes a patch is easier to read when split, but the split means that some sub-patch doesn't build.
In this case I think it is fine to note the issue in the email and then remember to squash the relevant patches at merge time.
Tom
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052