This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Test on disassemble


On 11/23/2013 02:21 AM, Tom Tromey wrote:
> Yao> +    global gdb_prompt
> Yao> +    set gdb_prompt "\[(\]top-gdb\[)\]"
> 
> It seems to me that this sort of change ought to be undone after the
> tests are complete.  Otherwise, it could affect subsequent tests.
> 
> To do that properly, you'll want to use "catch".  Or, if you want to
> wrap it up "macro style" see with_test_prefix.

A new proc with_gdb_prompt is added.  How about the patch below?

-- 
Yao (éå)

gdb/testsuite/

2013-11-25  Yao Qi  <yao@codesourcery.com>

	* lib/gdb.exp (with_gdb_prompt): New proc.
	* gdb.perf/disassemble.exp: New.
	* gdb.perf/disassemble.py: New.
---
 gdb/testsuite/gdb.perf/disassemble.exp |   57 ++++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.perf/disassemble.py  |   35 +++++++++++++++++++
 gdb/testsuite/lib/gdb.exp              |   26 ++++++++++++++
 3 files changed, 118 insertions(+), 0 deletions(-)
 create mode 100644 gdb/testsuite/gdb.perf/disassemble.exp
 create mode 100644 gdb/testsuite/gdb.perf/disassemble.py

diff --git a/gdb/testsuite/gdb.perf/disassemble.exp b/gdb/testsuite/gdb.perf/disassemble.exp
new file mode 100644
index 0000000..8f07a59
--- /dev/null
+++ b/gdb/testsuite/gdb.perf/disassemble.exp
@@ -0,0 +1,57 @@
+# Copyright (C) 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# This test case is to test the speed of GDB when it is doing disassemble
+# some large functions in GDB.
+load_lib perftest.exp
+
+if [skip_perf_tests] {
+    return 0
+}
+
+global GDB
+
+standard_testfile .c
+# Overwrite $binfile
+set binfile $GDB
+
+PerfTest::assemble {
+    # Don't have compilation step.
+    return 0
+} {
+    global srcdir subdir
+    global binfile
+
+    gdb_exit
+    gdb_start
+    gdb_reinitialize_dir $srcdir/$subdir
+
+    # When GDB is debugging GDB, the prompt is changed to "(top-gdb) ".
+    # In order to avoid the confusion of pattern matching, set the
+    # gdb_prompt to '(top-gdb)' temporarily.
+    with_gdb_prompt "\\(top-gdb\\)" {
+	gdb_load ${binfile}
+    }
+
+    # The prompt of both parent GDB and child GDB is '(gdb)', but
+    # child GDB's prompt doesn't confuse pattern matching because but
+    # we only run to main function of child GDB, so child GDB's
+    # prompt can't be printed out.
+    if ![runto_main] {
+	return -1
+    }
+} {
+    gdb_test "python Disassemble\(\).run()"
+}
diff --git a/gdb/testsuite/gdb.perf/disassemble.py b/gdb/testsuite/gdb.perf/disassemble.py
new file mode 100644
index 0000000..fac1638
--- /dev/null
+++ b/gdb/testsuite/gdb.perf/disassemble.py
@@ -0,0 +1,35 @@
+# Copyright (C) 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+from perftest import perftest
+
+class Disassemble(perftest.TestCaseWithBasicMeasurements):
+    def __init__(self):
+        super (Disassemble, self).__init__ ("disassemble")
+
+    def warm_up(self):
+        do_test_command = "disassemble ada_evaluate_subexp"
+        gdb.execute (do_test_command, False, True)
+
+    def _do_test(self, c):
+        for func in ["evaluate_subexp_standard", "handle_inferior_event", "c_parse_internal"]:
+            do_test_command = "disassemble %s" % func
+            for _ in range(c+1):
+                gdb.execute (do_test_command, False, True)
+
+    def execute_test(self):
+        for i in range(3):
+            self.measure.measure(lambda: self._do_test(i), i)
+
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index b8b21ab..2c1cf29 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -1716,6 +1716,32 @@ proc with_test_prefix { prefix body } {
   }
 }
 
+# Run tests in BODY with GDB prompt and variable $gdb_prompt set to
+# PROMPT.  When BODY is finished, restore GDB prompt and variable
+# $gdb_prompt.
+# Returns the result of BODY.
+
+proc with_gdb_prompt { prompt body } {
+    global gdb_prompt
+
+    set saved $gdb_prompt
+
+    set gdb_prompt $prompt
+    gdb_test_no_output "set prompt $prompt " ""
+
+    set code [catch {uplevel 1 $body} result]
+
+    set gdb_prompt $saved
+    gdb_test_no_output "set prompt $saved " ""
+
+    if {$code == 1} {
+	global errorInfo errorCode
+	return -code $code -errorinfo $errorInfo -errorcode $errorCode $result
+    } else {
+	return -code $code $result
+    }
+}
+
 # Return 1 if _Complex types are supported, otherwise, return 0.
 
 gdb_caching_proc support_complex_tests {
-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]