This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Stan Shebs <stan at codesourcery dot com>
- Date: Tue, 12 Nov 2013 13:16:32 -0800
- Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
- Authentication-results: sourceware.org; auth=none
- References: <20131105172219 dot GA21529 at host2 dot jankratochvil dot net> <CADPb22Tcg9g=pCG1q07hK6DkRnTQop7bZynqnoN+upiuDBWsZA at mail dot gmail dot com> <20131105180547 dot GA24004 at host2 dot jankratochvil dot net> <CADPb22S4ivEm=abcrxLBQwiB9yrB7CryvOBNi+rh-GdOpek5nQ at mail dot gmail dot com> <20131106212434 dot GA4193 at host2 dot jankratochvil dot net> <CADPb22RZUByzjAyogDznmBj0vPUBKCWevUoH1mN97V36oLWsCA at mail dot gmail dot com> <20131107190059 dot GA24230 at host2 dot jankratochvil dot net> <21117 dot 8566 dot 225807 dot 905608 at ruffy dot mtv dot corp dot google dot com> <20131108175033 dot GA11849 at host2 dot jankratochvil dot net> <CADPb22QadnmVhw6oQMGm3Gg8qYwuGucypocX_ZfwGzfp5AJ5TA at mail dot gmail dot com> <20131112184556 dot GA20259 at host2 dot jankratochvil dot net>
On Tue, Nov 12, 2013 at 10:45 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Tue, 12 Nov 2013 19:33:33 +0100, Doug Evans wrote:
>> https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards
>>
>> Feel free to tweak or add whatever community rules there are.
>> I'll add more as it occurs to me.
>
> FYI I find
> In C code, don't use K&R function definitions
>
> redundant against the part above
> The best guidance one can give is that unless a test requires
> a particular style (which is rare) you can't go wrong following the
> GDB coding standards.
>
> but it is OK even as a redundant text.
Eh? It is not redundant, that was the whole point of this thread.
Following the GDB coding standards is not a rule.