This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Stan Shebs <stan at codesourcery dot com>
- Date: Fri, 8 Nov 2013 09:37:58 -0800
- Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
- Authentication-results: sourceware.org; auth=none
- References: <20131031154957 dot GA11260 at host2 dot jankratochvil dot net> <CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A at mail dot gmail dot com> <87li13shk2 dot fsf at fleche dot redhat dot com> <CADPb22QNaGzvagsDwgt2mAVOQw9kQxtKbnHKtnTbUMy-7xaJhw at mail dot gmail dot com> <20131105172219 dot GA21529 at host2 dot jankratochvil dot net> <CADPb22Tcg9g=pCG1q07hK6DkRnTQop7bZynqnoN+upiuDBWsZA at mail dot gmail dot com> <20131105180547 dot GA24004 at host2 dot jankratochvil dot net> <CADPb22S4ivEm=abcrxLBQwiB9yrB7CryvOBNi+rh-GdOpek5nQ at mail dot gmail dot com> <20131106212434 dot GA4193 at host2 dot jankratochvil dot net> <CADPb22RZUByzjAyogDznmBj0vPUBKCWevUoH1mN97V36oLWsCA at mail dot gmail dot com> <20131107190059 dot GA24230 at host2 dot jankratochvil dot net>
Jan Kratochvil writes:
> On Thu, 07 Nov 2013 18:32:08 +0100, Doug Evans wrote:
> > I don't mind such changes, but these are changes. Agreed?
> So far I have expexted testsuite should follow the GDB coding standards and
> reviewers only have various reasons (*) why not to enforce the coding
> standards so strictly (or at all) for the testsuite.
All the GDB coding standards?
The testsuite is replete with various violations.
[One might suggest requiring new tests to explicitly mark themselves
as standard-compliant or non-compliant so that we can pass the plethora
of -Wfoo that we pass for GDB. I wouldn't disagree that that's perhaps
too much. :-)]
I don't have a strong opinion, so I'm not the one you have to convince.
[I do have a strong opinion that whatever the rules are, they be written
down of course.]
> (*) save time of both the submitter and reviewer, making patch acceptance
> easier for submitters etc.
> > I was trying to end the thread, and make some minimal mutually agreeable
> > progress.
> I would also like so.
I feel more comfortable getting approval for the modest changes I've proposed,
making some progress, while leaving the general discussion to another thread.
Either way is fine with me.
No one has objected to my proposal (which isn't necessarily decisive
Propose yours and see what happens (please start a separate thread though
so the Subject line is more appropriate). Being a more substantive change,
I'd feel more comfortable with explicit approval from all the GMs,
as opposed to passive non-disapproval. :-)