This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Perf test framework
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 04 Nov 2013 09:24:30 -0700
- Subject: Re: [PATCH 2/4] Perf test framework
- Authentication-results: sourceware.org; auth=none
- References: <1383291300-13917-1-git-send-email-yao at codesourcery dot com> <1383291300-13917-3-git-send-email-yao at codesourcery dot com> <877gcryhnz dot fsf at fleche dot redhat dot com> <52746636 dot 8080102 at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> * lib/perftest.exp: New.
Yao> * gdb.perf/lib/perftest/__init__.py: New.
Yao> * gdb.perf/lib/perftest/measure.py: New.
Yao> * gdb.perf/lib/perftest/perftest.py: New.
Yao> * gdb.perf/lib/perftest/reporter.py: New.
Yao> * gdb.perf/lib/perftest/testresult.py: New.
Thanks for making that change, Yao.
One more little nit:
Yao> + if { "$GDB_PERFTEST_MODE" != "compile"
Yao> + && "$GDB_PERFTEST_MODE" != "run"
Yao> + && "$GDB_PERFTEST_MODE" != "both" } {
Yao> + # GDB_PERFTEST_MODE=compile|run|both is allowed.
Yao> + unsupported "Unknown value of GDB_PERFTEST_MODE."
Yao> + return 1
This is basically an internal error.
Calling "error" and having a backtrace in the log seems better to me.
Tom