This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts.
- From: Keith Seitz <keiths at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'gdb-patches'" <gdb-patches at sourceware dot org>
- Date: Mon, 30 Sep 2013 18:19:37 -0700
- Subject: Re: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts.
- Authentication-results: sourceware.org; auth=none
- References: <002901cebaf2$35ec65a0$a1c530e0$ at muller@ics-cnrs.unistra.fr> <003b01cebaf3$a2d79620$e886c260$ at muller@ics-cnrs.unistra.fr>
Hi, Pierre,
On 09/26/2013 01:04 PM, Pierre Muller wrote:
The first part has to do with the fact that GDB prints
the memory address and the closest symbol while the test
doesn't cope for this.
I simply fixed this by setting/unsetting printing of
addresses and symbols at specific locations.
Can you provide an example? I notice no difference on linux with/without
those options set. Is the output really different on MinGW? [I wouldn't
have guessed that they are.]
In any case, this bit seems harmless enough. If you say it fixes
problems, I believe you, and I'm all for it!
The last errors were generated by the use of Ctrl-V
to avoid problems with possible association of @ to kill command.
mingw GDB doesn't handle this Ctrl-V, so I conditionally removed it for
*-*-mingw* hosts.
This isn't so much a question for you specifically, but I thought I'd
throw this out to the greater wisdom of the list.
I searched around the test suite and found a bunch of places where this
character is used without the ^V hack. Is it (still) necessary at all?
Perhaps we can just get rid of it entirely?
Otherwise, given the harmless nature of the changes, I'd recommend that
a maintainer approve this.
Keith