RE: [RFC 5/6] Handle "set print sevenbit-strings on" in print_wchar

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : vendredi 27 septembre 2013 17:14
> À : Pierre Muller
> Cc : 'gdb-patches'
> Objet : Re: [RFC 5/6] Handle "set print sevenbit-strings on" in
print_wchar
> 
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
writes:
> 
> Pierre>   When "set print sevenbit-strings on"
> Pierre> is used, all characters above 127 should be displayed as
> Pierre> escapes.
> 
> Pierre>   This patch does just that.
> 
> Does it fix any test?
  This helps a lot in reducing the number
of failures on mingw hosts for gdb.base/printcmds.exp

https://sourceware.org/bugzilla/show_bug.cgi?id=15873

Basically it all comes from the fact that
by default mingw host GDb have a default charset which allow
to print most chars between 128 and 255 numeric value,
thus leading to failures when printing ctable1[x]
for x in that range.

> If so, could you say which one?
> If not, please add a test case.
  As said, its already in printcmds.exp 
> Do you actually use this setting?  I'm curious.

  I don't but this test does!

Pierre

PS: The fact that the results are better for executables
that have UTF-8 as default charset is an error in my opinion,
as no warning is printed for invalid or incomplete sequence chars!
  But this was in my first by RFC, and I did not yet
resubmit it in this series.