This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA, doc RFA] Add "set debug symfile on".
- From: Doug Evans <dje at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>, Eli Zaretskii <eliz at gnu dot org>
- Date: Tue, 24 Sep 2013 17:31:07 -0700
- Subject: Re: [RFA, doc RFA] Add "set debug symfile on".
- Authentication-results: sourceware.org; auth=none
- References: <yjt261tpbvdj dot fsf at ruffy dot mtv dot corp dot google dot com>
On Tue, Sep 24, 2013 at 5:25 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch adds a new debugging option: set debug symfile on
>
> For now it logs all calls through the symfile functions.
>
> Regression tested on amd64-linux.
>
> Ok to check in?
>
> 2013-09-24 Doug Evans <dje@google.com>
>
> New option "set debug symfile on".
> * NEWS: Mention "set debug symfile".
> * Makefile.in (SFILES): Add symfile-debug.c.
> (COMMON_OBS): Add sumfile-debug.o.
> * elfread.c (elf_symfile_read): Use objfile_set_sym_fns to set the
> objfile's symbol functions.
> * objfiles.h (objfile_set_sym_fns): Declare.
> * dwarf2read.c (dw2_map_matching_symbols): Update signature.
> * psymtab.c (map_matching_symbols_psymtab): Update signature.
> * symfile-debug.c: New file.
> * symfile.c (sym_fns_ptr): Delete. Replace with ...
> (registered_sym_fns): ... this.
> (symtab_fns): Update.
> (syms_from_objfile_1): Use objfile_set_sym_fns to set the objfile's
> symbol functions.
> (reread_symbols): Ditto.
> (add_symtab_fns): New arg "flavour". All callers updated.
> (find_sym_fns): Rewrite to use new sym_fns registry.
> * symfile.h (struct quick_symbol_functions): Reorg arg list of
> map_matching_symbols so objfile is first.
> (struct sym_fns): Delete member "sym_flavour". All uses updated.
> Add "objfile" argument to sym_read_linetable. All uses updated.
> (add_symtab_fns): Update prototype.
> * symtab.c (domain_name, search_domain_name): New functions.
> * symtab.h (domain_name, search_domain_name): Declare.
>
> doc/
> * gdb.texinfo (Debugging Output): Document set/show debug symfile.
Oh. Also tested with --enable-targets=all