This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 24 Sep 2013 18:53:02 +0200 (CEST)
- Subject: Re: [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments
- Authentication-results: sourceware.org; auth=none
- References: <20130920232017 dot GU3132 at adacore dot com> <1380040404-16932-1-git-send-email-brobecker at adacore dot com>
> From: Joel Brobecker <brobecker@adacore.com>
> Date: Tue, 24 Sep 2013 09:33:20 -0700
>
> Hello,
>
> > Once again, I'm short of time to finish what I had hoped to be able
> > to complete. But I thought I'd send an update anyway. The first patch
> > is an update to the patch I wrote in January, rebased for today's HEAD.
> > This is what I have tested and intend to check in soon.
> >
> > Left to do on my end, is clean things up in amd64-tdep, because many
> > hooks in the tdep structure can now be removed, and replaced by
> > direct calls. But this is independent of your changes, so we can
> > both work at the same time.
>
> I have now checked in the patch re-implementing function call on
> amd64-windows. After this was done, I was able to revert all changes
> that added hooks in the gdbarch_tdep and in the amd64 sysV code
> to tweak it for amd64-windows, since the two implementations are
> now completely distinct.
>
> All patches were tested on x86_64-linux and x86_64-windows.
> And just in case, I tested them on x86-windows as well.
Thanks a bunch Joel!