This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR server/15959
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 18 Sep 2013 14:24:02 +0100
- Subject: Re: [PATCH] Fix PR server/15959
- Authentication-results: sourceware.org; auth=none
- References: <1379391203-14928-1-git-send-email-yao at codesourcery dot com> <0377C58828D86C4588AEEC42FC3B85A71767DCAA at IRSMSX105 dot ger dot corp dot intel dot com> <52381E7A dot 9000503 at codesourcery dot com> <52387BFC dot 1010003 at redhat dot com> <5239058D dot 5020400 at codesourcery dot com>
On 09/18/2013 02:44 AM, Yao Qi wrote:
> On 09/17/2013 11:57 PM, Pedro Alves wrote:
>> Missing space after parens (you added it in "marker").
>>
>>>> +{
>>>> + d = getenv("TEST");
>> Here too.
>>
>
> Fixed.
>
>>>> +
>>>> + marker ();
>>>> +
>>>> + return 0;
>>>> +}
>> I think the test will fail on Windows, because there's no
>> "env" binary there. I think we should first try to see
>> if running "env" works, with "remote_exec target", and
>> mark the test UNSUPPORTED if it doesn't.
>
> We are testing mingw32 native gdb in cygwin, so "env" is there (shipped
> from cygwin), but gdbserver is still unable to create process with
> "env TEST=1".
Actually, even though "env" is available on Cygwin, --wrapper doesn't
really work there. --wrapper works by gdbserver expecting more
more exec/trap in the initial create_inferior phase, but the Windows
debug API is different, there are no execs at all like that.
$ ./gdbserver.exe --wrapper /usr/bin/env TEST=1 -- :9999 /usr/bin/echo 1
Process /usr/bin/echo created; pid = 488
1
Child exited with status 0
No program to debug. GDBserver exiting.
$
(gdbserver did one resume too many, and didn't actually end up debugging
the right process)
I've filed PR server/15967 for that.
> I mark test unsupported and return on mingw target in the updated patch.
Thanks. I've applied this follow up.
Subject: [COMMIT PATCH] gdbserver --wrapper also doesn't work on Cygwin.
Skip the test on Cygwin too.
2013-09-18 Pedro Alves <palves@redhat.com>
PR server/15967
* gdb.server/wrapper.exp: Also return unsupported for Cygwin, and
change text.
---
gdb/testsuite/gdb.server/wrapper.exp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
index 5b2e2b7..a5fb714 100644
--- a/gdb/testsuite/gdb.server/wrapper.exp
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -25,8 +25,9 @@ if { [skip_gdbserver_tests] } {
return 0
}
-if [istarget *-*-mingw*] {
- unsupported "Command env doesn't exist on Windows."
+if { [istarget *-*-mingw*]
+ || [istarget *-*-cygwin*] } {
+ unsupported "gdbserver does not support --wrapper on this target (PR server/15967)"
return -1
}
--
1.7.11.7