This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add new function to access gdb_program_name.
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "Tom Tromey" <tromey at redhat dot com>
- Date: Wed, 18 Sep 2013 12:47:59 +0100
- Subject: Re: [PATCH] Add new function to access gdb_program_name.
- Authentication-results: sourceware.org; auth=none
- References: <5229CC5F dot 4030309 at broadcom dot com> <87wqmqj5u4 dot fsf at fleche dot redhat dot com>
On 09/09/2013 5:52 PM, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
>
> Andrew> The deprecated_init_ui_hook is used from gdbtk just to get hold
> Andrew> of gdb's argv[0].
>
> Andrew> We currently hold this in the variable gdb_program_name within
> Andrew> main.c, so adding a read only accessor function does not feel
> Andrew> unreasonable to me, and would allow gdbtk to stop using
> Andrew> deprecated_init_ui_hook.
>
> Andrew> What do you think?
>
> Seems reasonable to me.
>
> Andrew> +extern const char * get_gdb_program_name (void);
>
> Extra space here after the "*".
>
> Ok with that changed.
Committed.
I managed to fail at fixing the extra whitespace as you
requested, so I made a second commit, to fix the
whitespace.
Sorry for that,
Andrew
2013-09-18 Andrew Burgess <aburgess@broadcom.com>
* main.h (get_gdb_program_name): Remove extra whitespace.
diff -u -p -r1.18 main.h
--- ./gdb/main.h 18 Sep 2013 11:41:38 -0000 1.18
+++ ./gdb/main.h 18 Sep 2013 11:43:39 -0000
@@ -46,6 +46,6 @@ extern char *windows_get_absolute_argv0
might have been expanded to an absolute path if required by the
platform. Could return NULL if called before gdb has had a chance to
parse the argv array. */
-extern const char * get_gdb_program_name (void);
+extern const char *get_gdb_program_name (void);
#endif