This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Print thread name when executing thread commands



On Wed, 18 Sep 2013, Pat Pannuto wrote:

Currently the thread family of commands only prints the thread ID and
PID. GDB also has access to the thread's name, which is often an easier
way of quickly identifying a thread. This simple patch uses the same
mechanism as `info threads' to get the name of a thread and add it to
the thread identifier line when it's printed.

I wrapped the name in []'s to offset it and make it visually distinct
from the ()'s that wrap the other thread information. I'm not at all
attached to this look, just looked best to me.

Diff should be from current cvs. This is my first patch to GDB, if I
messed something up don't hesitate to yell at me.

I'm fairly new here too so maybe I shouldn't say too much, but supplying the patch inline (including the ChangeLog entry) in the post makes it much easier to comment on it. I still like adding it as an attachement lest the mail program messes up the formatting so it doesn't apply.

My initial comment is that the ChangeLog format requires that it should be more specific regarding which functions have been modified. One should be able to grep for the function name in the ChangeLog. Something like

2013-09-18  Pat Pannuto  <pat.pannuto@gmail.com>

        * thread.c (thread_apply_all_command, thread_apply_command):
	Print thread name as well as ID number and PID.

In the code, there was a 'char *name' in one place, but 'char* name' in another. Looking quickly, the indentation of multiple-line statements looked inconsistent in some places too.

As for the functionality itself, I'm not in a position to approve but I think it's a good idea. It's annoying just to get the thread id when there's more information available. I don't know if there are any caveats.

/Ricard
--
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]