This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[COMMITTED][RFC/TileGX 1/2] fix gdbserver build failure
- From: Jiong Wang <jiwang at tilera dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 17 Sep 2013 22:04:41 +0800
- Subject: [COMMITTED][RFC/TileGX 1/2] fix gdbserver build failure
- Authentication-results: sourceware.org; auth=none
- References: <50F9148F dot 3010602 at tilera dot com> <5237C847 dot 3040908 at tilera dot com> <20130917123042 dot GD3132 at adacore dot com> <52384C0E dot 1070808 at tilera dot com> <5238574F dot 1000509 at tilera dot com> <20130917133023 dot GG3132 at adacore dot com> <52385AEF dot 5070404 at tilera dot com> <20130917134309 dot GI3132 at adacore dot com>
On 09/17/2013 09:43 PM, Joel Brobecker wrote:
linux-tile-low.o is the target file of TileGX. (it's name is confusing ?)
previous commit by the following wrongly removed the tilegx target file.
commit f7fc28008a4d76dd6e55eb77070eb18e956406a9
Author: Luis Machado <luisgpm@br.ibm.com>
Date: Thu Aug 22 23:46:27 2013 +0000
- srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o"
- srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
+ srv_tgtobj="$srv_linux_obj linux-osdata.o"
Ok. Thank you for that, I had missed that commit in my research.
That goes to show how important it is to send detailed descriptions
of the problem when sending a patch. Otherwise, we end up wasting
time trying to figure it out again.
I knew what the file was about, and I knew it made sense. But I'd like
every patch to be explained on this list before it gets checked in.
This is for later on, when someone tries to figure out why a patch
was applied, at least it's documented in one public place.
understand.
thanks for careful review.
commited.
2013-09-16 Jiong Wang <jiwang@tilera.com>
* configure.srv <tilegx*-*-linux*>: Remove linux-osdata.o from and add
linux-tile-low.o to srv_tgtobj.
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.79
retrieving revision 1.80
diff -u -r1.79 -r1.80
--- src/gdb/gdbserver/configure.srv 2013/09/13 14:17:30 1.79
+++ src/gdb/gdbserver/configure.srv 2013/09/17 13:56:54 1.80
@@ -340,7 +340,7 @@
;;
tilegx-*-linux*) srv_regobj=reg-tilegx.o
srv_regobj="${srv_regobj} reg-tilegx32.o"
- srv_tgtobj="$srv_linux_obj linux-osdata.o"
+ srv_tgtobj="$srv_linux_obj linux-tile-low.o"
srv_linux_regsets=yes
srv_linux_thread_db=yes
;;
Please go ahead and commit.