This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] PR 15520 - GDB step command crashed on non-stop mode
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Muhammad Waqas' <mwaqas at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 17 Sep 2013 07:19:24 +0000
- Subject: RE: [PATCH] PR 15520 - GDB step command crashed on non-stop mode
- Authentication-results: sourceware.org; auth=none
- References: <5236BD0B dot 9090802 at codesourcery dot com>
Hello Muhammad,
I looked at the test only as I lack knowledge about the stepping/breakpoint algorithm.
A single comment below.
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Muhammad Waqas
> Sent: Monday, September 16, 2013 10:11 AM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] PR 15520 - GDB step command crashed on non-stop mode
>
> Index: testsuite/gdb.base/pr15520.exp
> ===================================================================
> RCS file: testsuite/gdb.base/pr15520.exp
> diff -N testsuite/gdb.base/pr15520.exp
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ testsuite/gdb.base/pr15520.exp 16 Sep 2013 08:06:03 -0000
> @@ -0,0 +1,36 @@
>[...]
> +
> +if ![runto_main] {
> + untested non-stop-step
> + return -1
> +}
> +
> +gdb_test "set target-async on" ".*" "Set async mode"
> +gdb_test "set non-stop on" ".*" "Set non stop mode"
>
Use gdb_test_no_output instead of gdb_test.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052