This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv3 1/5] Mostly code cleanup: Constification
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Sep 2013 08:48:41 +0200
- Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification
- Authentication-results: sourceware.org; auth=none
- References: <20130915193742 dot GA20411 at host2 dot jankratochvil dot net> <21047 dot 33940 dot 998451 dot 19883 at ruffy dot mtv dot corp dot google dot com>
On Tue, 17 Sep 2013 00:22:12 +0200, Doug Evans wrote:
> Jan Kratochvil writes:
> > - catch_command_errors (symbol_file_add_main, symarg,
> > - !batch_flag, RETURN_MASK_ALL);
> > + {
> > + volatile struct gdb_exception e;
> > +
> > + TRY_CATCH (e, RETURN_MASK_ALL)
> > + {
> > + symbol_file_add_main (symarg, !batch_flag);
> > + }
> > + exception_print (gdb_stderr, e);
> > + }
> > }
> >
> > if (corearg && pidarg)
>
> There is catch_command_errors_const.
> Would that work here?
It would work here. But I thought catch_command_errors* is deprecated in
favor of TRY_CATCH. Maybe I could split this patch in two, but the end would
be the same.
Jan