This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 09/09/13 22:26, Hui Zhu wrote:
On Mon, Sep 9, 2013 at 9:45 PM, Yao Qi <yao@codesourcery.com> wrote:On 09/09/2013 04:40 PM, Hui Zhu wrote:- send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n" + if { "${plus_var}" == "" } { + send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n" + } else { + send_gdb "shell grep -E \" ${plus_var} .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n" + }Why don't do this unconditionally? send_gdb "shell grep -E \" T .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"Because other test use this function too. Thanks, Hui-- Yao (éå)
Hi, After dicsussion with Yao. I got that on any targets, fn_[12] should be in .text section, so 'T' should work for all targets. And the purpose of this test is to make sure that " (msymbol) relocated functions have different addresses". So I change this patch to just check "T" symbol for any target. Thanks, Hui 2013-09-12 Hui Zhu <hui@codesourcery.com> * gdb.base/shreloc.exp (get_msym_addrs): Add argument "plus_var". (check_different): Ditto. ((msymbol) relocated functions have different addresses): Add argument 'T' when call check_different.
Attachment:
fix-cygwin-shreloc.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |