This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v4 07/24] record-btrace: optionally indent function call history
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Himpel, Christian" <christian dot himpel at intel dot com>
- Date: Tue, 10 Sep 2013 15:08:37 +0200
- Subject: Re: [patch v4 07/24] record-btrace: optionally indent function call history
- Authentication-results: sourceware.org; auth=none
- References: <1372842874-28951-1-git-send-email-markus dot t dot metzger at intel dot com> <1372842874-28951-8-git-send-email-markus dot t dot metzger at intel dot com> <20130818190623 dot GF24153 at host2 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B230A9CAAF4 at IRSMSX104 dot ger dot corp dot intel dot com>
On Tue, 10 Sep 2013 15:06:00 +0200, Metzger, Markus T wrote:
> What should we do with text output like "inst" and "at" below.
You are right it should be also localized.
> > > + ui_out_text (uiout, "\tinst ");
>
> Would I split this to separate "inst" from the formatting?
> Or is it OK to just say '_("\tinst ")'?
_("\tinst ") is OK.
Thanks,
Jan