This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Test case for entry values.
- From: Vidya Praveen <vidyapraveen at arm dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 30 Aug 2013 16:29:28 +0100
- Subject: Re: [PATCH 1/2] Test case for entry values.
- Authentication-results: sourceware.org; auth=none
- References: <1376379586-24150-1-git-send-email-yao at codesourcery dot com> <1376379586-24150-2-git-send-email-yao at codesourcery dot com> <5220B1B6 dot 2000304 at arm dot com>
On Fri, Aug 30, 2013 at 03:52:38PM +0100, Vidya Praveen wrote:
> Hi Yao Qi,
>
> On 08/13/13 08:39, Yao Qi wrote:
> [...]
> > +set bar_length ""
> > +set bar_call_foo ""
> > +
> > +# Calculate the offset of the last instruction from the beginning.
> > +set test "disassemble bar"
> > +gdb_test_multiple $test $test {
> > + -re ".*$hex <\\+$decimal>:\[ \t\]+call\[^\r\n\]+\r\n\[ \]+$hex <\\+($decimal)>:" {
>
> If I understand it right, this expects a 'call' instruction. Isn't this target
> specific?
Sorry I missed this comment:
+if [string equal $bar_call_foo ""] {
+ fail "Find the call or branch instruction offset in bar"
+ # The following test makes no sense if the offset is unknown. We need
+ # to update the pattern above to match call or branch instruction for
+ # the target architecture.
+ return -1
+}
This test fails for ARM targets as they generate 'bl'.
Regards
VP