This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: FYI: fix test name in gdb-index.exp
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 28 Aug 2013 07:55:14 -0700
- Subject: Re: FYI: fix test name in gdb-index.exp
- Authentication-results: sourceware.org; auth=none
- References: <87vc2px5g3 dot fsf at fleche dot redhat dot com>
TIL: It's not just that test names have to be unique, but they can no
longer include build directory names because the latter can be machine
generated, and when diff'ing before/after runs it can lead to spurious
output needing investigating.
Good to know, thanks. And good thing to add to the testcase cookbook.
On Wed, Aug 28, 2013 at 7:20 AM, Tom Tromey <tromey@redhat.com> wrote:
> I'm checking this in.
>
> The new gdb-index.exp test included a directory name in a test name.
> This lead to spurious failures for me, because I ran the baseline tests
> in a different directory.
>
> Tom
>
> 2013-08-28 Tom Tromey <tromey@redhat.com>
>
> * gdb.dwarf2/gdb-index.exp (add_gdb_index): Use explicit test name
> when saving index.
>
> Index: gdb.dwarf2/gdb-index.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/gdb-index.exp,v
> retrieving revision 1.1
> diff -u -r1.1 gdb-index.exp
> --- gdb.dwarf2/gdb-index.exp 26 Aug 2013 18:43:40 -0000 1.1
> +++ gdb.dwarf2/gdb-index.exp 28 Aug 2013 14:17:05 -0000
> @@ -36,7 +36,8 @@
> set index_file ${program}.gdb-index
> verbose -log "index_file: ${index_file}"
> remote_file host delete ${index_file}
> - gdb_test_no_output "save gdb-index [file dirname ${index_file}]"
> + gdb_test_no_output "save gdb-index [file dirname ${index_file}]" \
> + "save gdb-index for file [file tail ${program}]"
>
> # No point in continuing if generating the index failed.
> # N.B.: There are times when gdb won't create an index, and it's not a