This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Yao Qi' <yao at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 28 Aug 2013 09:39:48 +0000
- Subject: RE: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf
- Authentication-results: sourceware.org; auth=none
- References: <520B7F70 dot 6070207 at codesourcery dot com> <1377663394-4975-1-git-send-email-yao at codesourcery dot com> <1377663394-4975-2-git-send-email-yao at codesourcery dot com>
lgtm, however I cannot approve your patch.
Minor comment below.
-Sanimir
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Yao Qi
> Sent: Wednesday, August 28, 2013 06:17 AM
> To: gdb-patches@sourceware.org
> Subject: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf
>
> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
> index a7b3d5c..34590de 100644
> --- a/gdb/testsuite/Makefile.in
> +++ b/gdb/testsuite/Makefile.in
> @@ -151,13 +151,18 @@ DO_RUNTEST = \
> export TCL_LIBRARY ; fi ; \
> $(RUNTEST)
>
> +# A list of all directories named "gdb.*" which also hold a .exp file.
> +# We filter out gdb.perf because it contains performance testing cases,
> +# and we don't want to run them together with other regression tests.
> +# They should be run separately by 'make check-perf'.
> +TEST_SRC_DIRS = $(filter-out gdb.perf,$(sort $(notdir $(patsubst %/,%,$(dir $(wildcard
> $(srcdir)/gdb.*/*.exp))))))
> +
> check-single: all $(abs_builddir)/site.exp
> - $(DO_RUNTEST) $(RUNTESTFLAGS)
> + $(DO_RUNTEST) --directory="$(TEST_SRC_DIRS)" $(RUNTESTFLAGS)
>
> -# A list of all directories named "gdb.*" which also hold a .exp file.
> # We filter out gdb.base and add fake entries, because that directory
> # takes the longest to process, and so we split it in half.
> -TEST_DIRS = gdb.base1 gdb.base2 $(filter-out gdb.base,$(sort $(notdir $(patsubst
> %/,%,$(dir $(wildcard $(srcdir)/gdb.*/*.exp))))))
> +TEST_DIRS = gdb.base1 gdb.base2 $(filter-out gdb.base ,$(TEST_SRC_DIRS))
>
You added whitespace after gdb.base.....................^
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052