This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method.
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 27 Aug 2013 08:48:57 +0800
- Subject: Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method.
- Authentication-results: sourceware.org; auth=none
- References: <20130823181245 dot 4023 dot 25651 dot stgit at brno dot lan>
On 08/24/2013 02:12 AM, Pedro Alves wrote:
main, so I can't imagine any regression from this. Does anyone want
(and is willing) to run this through the testsuite?
Pedro,
I tested this patch on mingw native GDB. There is no regression. Note
that I also applied two local patches to make the test result usable.
1. [PATCH] Unbuffer stdout and stderr on windows (reviewed but not
approved yet.)
https://sourceware.org/ml/gdb-patches/2013-08/msg00660.html
2. A hack to set stdout and stderr to binary mode.
-static int
-windows_xfer_memory (CORE_ADDR memaddr, gdb_byte *our, int len,
- int write, struct mem_attrib *mem,
- struct target_ops *target)
+static LONGEST
+windows_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
+ ULONGEST memaddr, LONGEST len)
It is not installed to deprecated_xfer_memory any more, so we need
documentation on this function.
--
Yao (éå)