This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds.


> -----Original Message-----
> From: Eli Zaretskii [mailto:eliz@gnu.org]
> Sent: Friday, August 23, 2013 4:37 PM
> To: Bunk, Bernd
> Cc: tromey@redhat.com; palves@redhat.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH v2] Added file properties to windows gdb executable
> for all mingw32 builds.
> 
> > From: "Bunk, Bernd" <bernd.bunk@intel.com>
> > CC: "tromey@redhat.com" <tromey@redhat.com>, "palves@redhat.com"
> > 	<palves@redhat.com>, "gdb-patches@sourceware.org"
> > 	<gdb-patches@sourceware.org>
> > Date: Fri, 23 Aug 2013 13:44:58 +0000
> >
> > > > +# check for environment variables to replace certain file
> > > > +properties [ -n "$WIN_EXE_VERSION" ] && version=$WIN_EXE_VERSION
> > > > +[ -n "$WIN_EXE_COMPANY_NAME" ] &&
> > > > +company_name=$WIN_EXE_COMPANY_NAME
> > > > +[ -n "$WIN_EXE_FILE_DESCRIPTION" ] &&
> > > > +file_description=$WIN_EXE_FILE_DESCRIPTION
> > > > +[ -n "$WIN_EXE_PRODUCT_NAME" ] &&
> > > > +product_name=$WIN_EXE_PRODUCT_NAME
> > > > +[ -n "$WIN_EXE_INTERNAL_NAME" ] &&
> > > > +internal_name=$WIN_EXE_INTERNAL_NAME
> > > > +[ -n "$WIN_EXE_ORIGINAL_FILENAME" ] &&
> > > > +original_filename=$WIN_EXE_ORIGINAL_FILENAME
> > > > +[ -n "$WIN_EXE_COPYRIGHT" ] && copyright=$WIN_EXE_COPYRIGHT [ -n
> > > > +"$WIN_EXE_LICENSE" ] && license=$WIN_EXE_LICENSE [ -n
> > > > +"$WIN_EXE_CONFIGURED" ] && configured=$WIN_EXE_CONFIGURED [ -n
> > > > +"$WIN_EXE_SUPPORT" ] && support=$WIN_EXE_SUPPORT
> > >
> > > This looks like unnecessary featurism to me.  Is it really needed,
> > > and if so, in what use cases?
> > Yes, it is needed. Not in here, but for every company which
> changes/adds and re-distributes gdb.
> > I started this feature because our Product Validation does not like
> binaries without legal information.
> > And off course this is different depending on who ships the product.
> > Without a way to change the strings the complete changeset would be
> useless for me.
> 
> You can always modify the source of these attributes, can't you?  It's
> not like you change these strings several times a day, right?
If I have to change/overwrite the sources for this feature just to use the feature, where would be the reason for me to upstream it?  I need parameters/env vars to customize the behavior during build, not changed sources that I need to merge for every branch I have.  The whole purpose of upstreaming a feature is to NOT have custom sources for this feature.

> 
> > > > +#include "afxres.h"
> > >
> > > Is this header really needed?
> > Yes, unfortunately.
> > This header file "implements" the resource language used below in the
> RC file.
> 
> Sorry, I don't understand: this header file in MinGW distribution just
> includes windows.h, defines IDC_STATIC, and that's it.  What do you
> have in it?
As clarified in another feedback - my mistake.  I changed it to 'include "version.h"' in v3.  I also tested it with using Visual Studio on this RC file - still functional.

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]