This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v4 22/24] infrun: reverse stepping from unknown functions
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 18 Aug 2013 21:09:26 +0200
- Subject: Re: [patch v4 22/24] infrun: reverse stepping from unknown functions
- References: <1372842874-28951-1-git-send-email-markus dot t dot metzger at intel dot com> <1372842874-28951-23-git-send-email-markus dot t dot metzger at intel dot com>
On Wed, 03 Jul 2013 11:14:32 +0200, Markus Metzger wrote:
> When reverse-stepping, only insert a resume breakpoint at ecs->stop_func_start
> if the function start is known. Otherwise, keep single-stepping.
A testcase would be nice but I understand the fix is obvious so OK without
a testcase.
>
> 2013-07-03 Markus Metzger <markus.t.metzger@intel.com>
>
> * infrun.c (handle_inferior_event): Check if we know the function
> start address.
>
>
> ---
> gdb/infrun.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/infrun.c b/gdb/infrun.c
> index dc1036d..bd44016 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -4939,7 +4939,7 @@ process_event_stop_test:
> or stepped back out of a signal handler to the first instruction
> of the function. Just keep going, which will single-step back
> to the caller. */
> - if (ecs->stop_func_start != stop_pc)
> + if (ecs->stop_func_start != stop_pc && ecs->stop_func_start != 0)
> {
> struct symtab_and_line sr_sal;
>
> --
> 1.7.1