This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] [PR gdb/15224] Fix incorrectly touched history file even if no commands get, added to it
- From: Pedro Alves <palves at redhat dot com>
- To: Muhammad Bilal <mbilal at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, jan dot kratochvil at redhat dot com
- Date: Tue, 13 Aug 2013 19:09:33 +0100
- Subject: Re: [PATCH 2/5] [PR gdb/15224] Fix incorrectly touched history file even if no commands get, added to it
- References: <52032A42 dot 5010408 at codesourcery dot com>
On 08/08/2013 06:18 AM, Muhammad Bilal wrote:
> History save should be perform on interactive debugging.
> so, using the input_from_terminal_p fixed this problem.
>
>
> 2013-08-08 Muhammad Bilal <mbilal@codesourcery.com>
>
> PR gdb/15224
(Just like PR cli/15715, all these bugs should each their own
different number, and then 15224 should be made dependent of
them. This patch is not about saving history by default, although
it is a necessary dependency for doing that.)
> * top.c (quit_force): Fixed incorrectly touching history file
> to use input_from_terminal_p.
"Fixed incorrectly" is a "why" and ambiguous (and sometimes, wrong).
Say:
* top.c (quit_force): Skip writing history file
if input is not from terminal.
Otherwise OK.
Thanks,
--
Pedro Alves