This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] Avoid invalid parameter warnings in C runtime function for mingw builtr GDB
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Thu, 8 Aug 2013 10:51:37 +0200
- Subject: [RFC] Avoid invalid parameter warnings in C runtime function for mingw builtr GDB
Lately I got several warnings with mingw built
GDB's:
warning: Invalid parameter passed to C runtime function.
Use the new "set stop-on-debug-string-event on"
command submitted previously in
http://sourceware.org/ml/gdb-patches/2013-08/msg00236.html
I was able to trace this down to
the fopen call with mode that to "re".
As stated in the source, the "e" mode is a glibc extension
about close on exec which generates this warning.
The patch below excludes this code if __MINGW32__ is defined,
but maybe it should be excluded if O_CLOEXEC is zero?
Comments welcome.
Pierre Muller
GDB pascal language maintainer
2013-08-07 Pierre Muller <muller@sourceware.org>
* src/gdb/common/filestuff.c (gdb_fopen_cloexec): Do not
try to use "e" mode if linking to Windows OS msvcrt DLL,
to avoid getting a output debug string event.
Index: src/gdb/common/filestuff.c
===================================================================
RCS file: /cvs/src/src/gdb/common/filestuff.c,v
retrieving revision 1.7
diff -u -p -r1.7 filestuff.c
--- src/gdb/common/filestuff.c 26 Jun 2013 08:01:55 -0000 1.7
+++ src/gdb/common/filestuff.c 7 Aug 2013 12:35:55 -0000
@@ -311,6 +311,7 @@ FILE *
gdb_fopen_cloexec (const char *filename, const char *opentype)
{
FILE *result = NULL;
+#ifndef __MINGW32__
static int fopen_e_ever_failed;
if (!fopen_e_ever_failed)
@@ -320,17 +321,21 @@ gdb_fopen_cloexec (const char *filename,
copy = alloca (strlen (opentype) + 2);
strcpy (copy, opentype);
/* This is a glibc extension but we try it unconditionally on
- this path. */
+ this path, except when using Windows OS msvcrt dll,
+ in order to avoid a output debug string event. */
strcat (copy, "e");
result = fopen (filename, copy);
}
+#endif
if (result == NULL)
{
/* Fallback. */
result = fopen (filename, opentype);
+#ifndef __MINGW32__
if (result != NULL)
fopen_e_ever_failed = 1;
+#endif
}
if (result != NULL)