This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Refactor common/target-common into meaningful bits
- From: Tom Tromey <tromey at redhat dot com>
- To: lgustavo at codesourcery dot com
- Cc: "'gdb-patches\ at sourceware dot org'" <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Thu, 01 Aug 2013 11:49:51 -0600
- Subject: Re: [PATCH] Refactor common/target-common into meaningful bits
- References: <51FA9649 dot 5060008 at codesourcery dot com>
>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
Luis> First, it seems like a good idea to stablish a more meaningful
Luis> directory structure as well, so we are moving target-common.[c|h] from
Luis> the "common" dir to the new "target" dir. This new directory will hold
Luis> anything more backend-related. For now it contains only generic target
Luis> definitions and functions.
I like it.
Luis> I've broken target-common.[c|h] into the following:
Luis> - target-resume.h: Definition for resume_kind.
Luis> - target-waitstatus.[c|h]: Definitions and code for anything related
Luis> to waitstatus.
Luis> - target-wait.h: A tiny bit that does not seem to fit properly in the
Luis> waitstatus files, so it is left here.
If I may be permitted to bikeshed just a bit longer...
Right now the file is named "target/target-waitstatus.h" and the code
says:
+#include "target-waitstatus.h"
I wonder whether you considered naming the file "target/waitstatus.h"
and having the code say:
+#include "target/waitstatus.h"
That is, let the directory provide the namespace service for us.
Tom